chore(android): gradle 8 #14014

AbdullahFaqeir · 2024-03-23T19:03:37Z

chore(android): let there be gradle 8
chore(android): fixed deprecations in kroll-apt project
chore(android): made kroll-apt incremental to enhance build time

GitHub issue: #13579

This PR is dedicated to my mentor Nafe Abboushi.

chore(android): fixed deprecations in kroll-apt project chore(android): made kroll-apt incremental to enhance build time

m1ga

Are the changes to the JAVA files necessary for the update? The more stuff that is changed, the more we have to test 😉

Also I wouldn't update the min and targetSDK with this PR. If we still can use 21 we should do that too. Same with target 34. I have a PR for that here #13940 as the broadcast receiver has to be adjusted.

So if that is not needed for the gradle PR please keep it as it is and do it in a separate PR (less changes, less testing).

I couldn't build a SDK locally. It's almost working but the last step titaniumPublication(MavenPublication) tries to publish it online instead of making a local repo? I've canceled it as it was uploading stuff 😄 Didn't want to publish something I don't need.

There aren't all cmake version available during build process. I have a different PR about that #13966 and I had to use 3.22.1 as that is available on all platforms.

fix(android): gradle 8 compatibility update to template build.gradle fix(android): revert dependency updates fix(android): revert minSdk and targetSdk

AbdullahFaqeir

All reviews applied.

fix(android): update _build.js & _buildModule.js for new gradle

m1ga · 2024-03-26T18:09:37Z

I have to do some testing but the first round was very good and I was able to build kitchensink an my app now 👍

Review will follow once I have more time to test

cb1kenobi

This is AWESOME! I don't wanna lose momentum on this PR.

I found a few indention nitpicks. I haven't tested the PR yet, but I spent some time researching some of the changes such as no longer need to call .setPackageName(). Good stuff!

What sort of testing do we need to do to get this over the finish line? I can test on Windows doing emulator builds as well as build-only device/dist builds. I don't have any working Android devices. Sigh.

cb1kenobi · 2024-05-01T04:56:55Z

android/build.gradle


 	repositories {
 		google()
 		mavenCentral()
 	}
 	dependencies {
-		classpath 'com.android.tools.build:gradle:7.0.4'
-		classpath 'com.google.gms:google-services:4.3.15'
+		classpath 'com.android.tools.build:gradle:8.3.1'


Is this the newest Gradle version we can upgrade to? I see 8.3 is over 8 months and 8.7 dropped about a month ago.

cb1kenobi · 2024-05-01T05:07:50Z

android/app/build.gradle

+					'src/main/assets',
+					"${projectDir}/../titanium/build/outputs/ti-assets"


Are these indentations intentional?

Suggested change

'src/main/assets',

"${projectDir}/../titanium/build/outputs/ti-assets"

'src/main/assets',

"${projectDir}/../titanium/build/outputs/ti-assets"

cb1kenobi · 2024-05-01T05:08:28Z

android/templates/build/ti.constants.gradle

 	tiAndroidXCoreLibVersion = '1.9.0'
 	tiAndroidXFragmentLibVersion = '1.5.7'
 	tiMaterialLibVersion = '1.6.1'
 	tiPlayServicesBaseLibVersion = '18.2.0'
 	tiManifestPlaceholders = [
-		tiActivityConfigChanges: 'density|fontScale|keyboard|keyboardHidden|layoutDirection|locale|mcc|mnc|navigation|orientation|screenLayout|screenSize|smallestScreenSize|touchscreen|uiMode'
+			tiActivityConfigChanges: 'density|fontScale|keyboard|keyboardHidden|layoutDirection|locale|mcc|mnc|navigation|orientation|screenLayout|screenSize|smallestScreenSize|touchscreen|uiMode'


cb1kenobi · 2024-05-01T05:09:32Z

android/titanium/build.gradle

+						'kroll.outputJsonFilePath': "${projectDir}/../../dist/android/titanium.bindings.json".toString(),
+						'kroll.outputCppDirPath'  : "${projectDir}/../runtime/v8/generated".toString(),
+						'kroll.jsModuleName'      : 'titanium'


Intentional indention?

Suggested change

'kroll.outputJsonFilePath': "${projectDir}/../../dist/android/titanium.bindings.json".toString(),

'kroll.outputCppDirPath' : "${projectDir}/../runtime/v8/generated".toString(),

'kroll.jsModuleName' : 'titanium'

'kroll.outputJsonFilePath': "${projectDir}/../../dist/android/titanium.bindings.json".toString(),

'kroll.outputCppDirPath' : "${projectDir}/../runtime/v8/generated".toString(),

'kroll.jsModuleName' : 'titanium'

cb1kenobi · 2024-05-01T05:09:53Z

android/titanium/build.gradle

+					'assets',
+					"${projectDir}/../modules/ui/assets"


Intentional indention?

Suggested change

'assets',

"${projectDir}/../modules/ui/assets"

'assets',

"${projectDir}/../modules/ui/assets"

cb1kenobi · 2024-05-01T05:10:09Z

android/titanium/build.gradle

+					'res',
+					"${projectDir}/../modules/ui/res"


Intentional indention?

Suggested change

'res',

"${projectDir}/../modules/ui/res"

'res',

"${projectDir}/../modules/ui/res"

cb1kenobi · 2024-05-01T05:10:24Z

android/titanium/build.gradle

+				"set(LIBV8_VERSION \"${packageJson.v8.version}\")",
+				"set(LIBV8_MODE \"${packageJson.v8.mode}\")"


Intentional indention?

Suggested change

"set(LIBV8_VERSION \"${packageJson.v8.version}\")",

"set(LIBV8_MODE \"${packageJson.v8.mode}\")"

"set(LIBV8_VERSION \"${packageJson.v8.version}\")",

"set(LIBV8_MODE \"${packageJson.v8.mode}\")"

cb1kenobi · 2024-05-01T05:11:32Z

android/untar.gradle

+			compression: project.properties.compression,
+			overwrite: project.properties.overwrite,
+			src: project.properties.src,
+			dest: project.properties.dest)


Intentional indention?

Suggested change

compression: project.properties.compression,

overwrite: project.properties.overwrite,

src: project.properties.src,

dest: project.properties.dest)

compression: project.properties.compression,

overwrite: project.properties.overwrite,

src: project.properties.src,

dest: project.properties.dest)

m1ga · 2024-05-01T08:27:40Z

What sort of testing do we need to do to get this over the finish line?

👍 @cb1kenobi I would love to split this up into smaller steps as this is a big PR:
#13579 (comment)
I have made older PRs: first one only updates the gradle files to the newer syntax, 2nd one updates cmake and checkstyle (looks much but it's only linting). Then we only have the gradle 8 parts in here and can focus on that as it's a bigger change.

chore(android): let there be gradle 8

f042d37

chore(android): fixed deprecations in kroll-apt project chore(android): made kroll-apt incremental to enhance build time

m1ga self-requested a review March 23, 2024 20:25

m1ga requested changes Mar 23, 2024

View reviewed changes

fix(android): revert change to java files

ac5b751

fix(android): gradle 8 compatibility update to template build.gradle fix(android): revert dependency updates fix(android): revert minSdk and targetSdk

AbdullahFaqeir commented Mar 24, 2024

View reviewed changes

fix(android): kitchensink-app not running after gradle 8

477d708

fix(android): update _build.js & _buildModule.js for new gradle

AbdullahFaqeir requested a review from m1ga March 26, 2024 17:37

m1ga mentioned this pull request Mar 26, 2024

Android: update gradle #13579

Open

m1ga changed the title ~~chore(android): let there be gradle 8~~ chore(android): gradle 8 Mar 26, 2024

m1ga self-assigned this Mar 26, 2024

m1ga mentioned this pull request Mar 28, 2024

Android update hansemannn/titanium-stripe#4

Open

cb1kenobi reviewed May 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(android): gradle 8 #14014

chore(android): gradle 8 #14014

AbdullahFaqeir commented Mar 23, 2024

m1ga left a comment

AbdullahFaqeir left a comment

m1ga commented Mar 26, 2024

cb1kenobi left a comment

cb1kenobi May 1, 2024

cb1kenobi May 1, 2024

cb1kenobi May 1, 2024

cb1kenobi May 1, 2024

cb1kenobi May 1, 2024

cb1kenobi May 1, 2024

cb1kenobi May 1, 2024

cb1kenobi May 1, 2024

m1ga commented May 1, 2024

		'src/main/assets',
		"${projectDir}/../titanium/build/outputs/ti-assets"

	tiActivityConfigChanges: 'density\|fontScale\|keyboard\|keyboardHidden\|layoutDirection\|locale\|mcc\|mnc\|navigation\|orientation\|screenLayout\|screenSize\|smallestScreenSize\|touchscreen\|uiMode'
	tiActivityConfigChanges: 'density\|fontScale\|keyboard\|keyboardHidden\|layoutDirection\|locale\|mcc\|mnc\|navigation\|orientation\|screenLayout\|screenSize\|smallestScreenSize\|touchscreen\|uiMode'

		"set(LIBV8_VERSION \"${packageJson.v8.version}\")",
		"set(LIBV8_MODE \"${packageJson.v8.mode}\")"

chore(android): gradle 8 #14014

Are you sure you want to change the base?

chore(android): gradle 8 #14014

Conversation

AbdullahFaqeir commented Mar 23, 2024

m1ga left a comment

Choose a reason for hiding this comment

AbdullahFaqeir left a comment

Choose a reason for hiding this comment

m1ga commented Mar 26, 2024

cb1kenobi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m1ga commented May 1, 2024